Storing table.inc in the includes folder puts it "in the way" for git add -A. Maybe this is not the best thing to do anyway, but it does seem like things would be improved if we moved table.inc to $HOME/.drush, or /etc/drush (if it is writable).

Comments

msonnabaum’s picture

msonnabaum commented

I'm not against this necessarily, but what if we just committed t a .gitignore with that in it?

greg.1.anderson’s picture

greg.1.anderson commented

I'm wary about the .gitignore idea. Could this cause trouble if the user wanted to use .gitignore to ignore their own temporary working files? Seems like it would be unfortunate if a git operation (e.g. git reset --hard HEAD) also reverted the contents of the .gitignore file.

moshe weitzman’s picture

moshe weitzman commented
Assigned: Unassigned » msonnabaum
Status: Active » Reviewed & tested by the community

I think that those users could use .gitignore at some other level of the tree. In general, adding a .gitignore as per #1 sounds good to me.

kotnik’s picture

kotnik commented

I'm also for adding table.inc to .gitignore. Can't count times I accidentally added it to the commit...

moshe weitzman’s picture

moshe weitzman commented
Status: Reviewed & tested by the community » Fixed

Added .gitignore to master and 4.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.