block_box_get fails with an ambiguous column error with PostGreSQL 8.1.

The boxes and blocks tables both contain a "title" column and this column is referenced without a qualifier in the query.

The error is most readily seen when configuring or deleting a custom block.

CommentFileSizeAuthor
#2 drupal-boxes-pgsql.diff369 bytesasaddi
drupal-block-ambiguous-column.diff507 bytesasaddi

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work

The title column should not be there. It is not in the MySQL version.

asaddi’s picture

asaddi commented
Version: 5.0-rc1 » 5.0-rc2
Component: block.module » system.module
Status: Needs work » Needs review
StatusFileSize
new drupal-boxes-pgsql.diff369 bytes

Ah. I withdraw my previous patch and submit a simpler patch against system.install.

It seems that users upgrading from 4.7.x shouldn't see this problem because of system_update_1006. However, I started from a fresh install of 5.0-rc1.

I'm not sure about the correct way to fix this in an automated manner since it seems like you would have to examine the table metadata (to check if the column exists) before dropping the column.

Personally, I'm just going to drop the column manually. :)

drumm’s picture

drumm
he/him
Location NY, US
commented
Version: 5.0-rc2 » 6.x-dev
Status: Needs review » Reviewed & tested by the community

Straightforward Postgres consistency fix.

dries’s picture

dries commented
Version: 6.x-dev » 5.x-dev

Committed to CVS HEAD. Thanks.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

Committed to 5.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)