the current data handler is extremely close, but always perform REQUEST_TIME - $value or some such. Instead format_interval($value).

CommentFileSizeAuthor
#5 1073378-time-interval.patch1.81 KBboombatower
#1 1073378-time-interval.patch1.84 KBboombatower

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new 1073378-time-interval.patch1.84 KB

Or pull from https://github.com/boombatower/views/tree/7.x-3.x-interval.

dawehner’s picture

dawehner
Primary language German
commented 

+      '#default_value' => isset($this->options['granularity']) ? $this->options['granularity'] : 2,

This line is not really needed :)
$this->options['granularity'] will be always filled up by the option_definition.

The rest looks fine. Needs manual testing.

boombatower’s picture

boombatower commented

Figured. I was following the pattern I saw in date and what not...those should probably all be changed?

dawehner’s picture

dawehner
Primary language German
commented

It's not such important.

Perhaps long ago views didn't autofilled the default values.

boombatower’s picture

boombatower commented
StatusFileSize
new 1073378-time-interval.patch1.81 KB

Remove isset.

dawehner’s picture

dawehner
Primary language German
commented
Assigned: boombatower » merlinofchaos

Assign for earl whether it should be commited to 7.x-3.x, or also for 6.x-3.x

boombatower’s picture

boombatower commented
Status: Needs review » Reviewed & tested by the community

Assume that means reviewed then.

merlinofchaos’s picture

merlinofchaos commented

This should go to 6.x-3.x as well as 7.x -- doesn't quite apply. dereine, feel free to commit to both

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Commited to both branches.

perhaps git commit --amend is a bad tool :) Never use it

a) on non-local commits
b) you commited something else in the meantime.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.