In the loop for writing rows, it uses foreach ($rows as $count => $row)

$count isn't a counter, it's the row index. We should change it to $row_index for clarity.

CommentFileSizeAuthor
#5 views-view-table_rename_var-1072296.patch912 bytesbarbi
#1 rename_count-1072296-1.patch985 bytesxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new rename_count-1072296-1.patch985 bytes

My very first drupal patch using git! Yay!

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

The patch doesn't apply to 6.x-3.x.

Could you add a patch for the other version too? This would be cool.

barbi’s picture

barbi commented

Newbie here. Can you help understand the issue here?
Should I clone "6.x-2.x", make the changes again and resubmit the patch?

dawehner’s picture

dawehner
Primary language German
commented

Please download the 6.x-3.x branch and try to make the same patch for it as well.

barbi’s picture

barbi commented
Version: 6.x-2.x-dev » 6.x-3.x-dev
Assigned: Unassigned » barbi
Status: Needs work » Needs review
StatusFileSize
new views-view-table_rename_var-1072296.patch912 bytes

Attaching patch for [branch "6.x-3.x"]

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

This definitive makes sense! Thanks

Committed to 6.x-3.x and 7.x-3.x

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.