Currently, if the password reset mail fails in user_pass_submit the user gets these two conflicting messages:

Unable to send e-mail. Please contact the site administrator if the problem persists.

Further instructions have been sent to your e-mail address.

Since _user_mail_notify provides a return value, we should check that before we print the second message.

Patch attached.

#3 user_pass_submit_message.patch1.01 KBArtusamak
PASSED: [[SimpleTest]]: [MySQL] 35,969 pass(es). View
user_pass_submit_message.patch1023 bytesmsonnabaum
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_pass_submit_message.patch. See the log in the details link for more information. View
Members fund testing for the Drupal project. Drupal Association Learn more


agentrickard’s picture

Status: Active » Needs review

Looks sane. Passing to testbed.

Status: Needs review » Needs work

The last submitted patch, user_pass_submit_message.patch, failed testing.

Artusamak’s picture

Status: Needs work » Reviewed & tested by the community
1.01 KB
PASSED: [[SimpleTest]]: [MySQL] 35,969 pass(es). View

You patch is misformatted, you now have to generate it with the prefix, that's why your patch failed to pass the testbost.
Here is the attachment of the fixed patch (which is working great).

webchick’s picture

Version: 7.x-dev » 8.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +needs backport to D7

Makes sense.

Committed and pushed to 8.x and 7.x. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -needs backport to D7

Automatically closed -- issue fixed for 2 weeks with no activity.