_field_info_prepare_instance calls the function field_info_field_types, but its return value is never used. field_info_field_types does not appear to make any state changes on its own (aside from storing its result in a cache), so this appears to serve no purpose.

CommentFileSizeAuthor
#4 remove_call-2_1067806.patch526 bytesstarsinmypockets
#3 remove_call_1067806.patch530 bytesstarsinmypockets

Comments

yched’s picture

yched commented

True. Probably a leftover after some refactoring. Care to roll a patch ? :-)

yched’s picture

yched commented
Issue tags: +Novice
starsinmypockets’s picture

starsinmypockets commented
StatusFileSize
new remove_call_1067806.patch530 bytes

Here's the patch... this is my first submitted patch does this look ok?

starsinmypockets’s picture

starsinmypockets commented
StatusFileSize
new remove_call-2_1067806.patch526 bytes

Sorry, the last patch introduced some whitespace. This one doesn't.

robloach’s picture

robloach
he/him
commented
Version: 7.x-dev » 8.x-dev
Status: Active » Needs review

Nice work on the patch :-) . Webchick won't commit anything unless it's in the Drupal 8.x branch first though. Looking at the code, the patch should be okay to go. Let's check with the Test Bot!

starsinmypockets’s picture

starsinmypockets commented
Assigned: RoboPhred » starsinmypockets
dries’s picture

dries commented
Assigned: starsinmypockets » RoboPhred
Status: Needs review » Fixed

Committed to 7.x and 8.x.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.