I am testing this module (while reviewing http://drupal.org/node/104047), but it's not Drupal 5 compatible.

Here is a beginning of an upgrade patch.

Comments

beginner’s picture

The patch above can first be committed.

Something else is missing, though: I donnot see the node type "event with volunteer timeslots" in node/add...

pwolanin’s picture

thanks, I haven't been paying attention to the event module, so I haven't yet seen if it's updated for 5.x.

pwolanin’s picture

Status: Needs review » Active

patch committed, but I'm sure there's more to do.

UMHockeyFan’s picture

Category: task » bug

I am running Drupal 5.1 and get the following error when I attempt to create an event with volunteer timeslots:

warning: array_merge_recursive() [function.array-merge-recursive]: Argument #2 is not an array in /afs/umich.edu/group/soas/habitat/Public/html/modules/node/node.module on line 1990.

In addition, the option to add this content only shows up in the navigation bar, it does not show up in the main create content page.

Thanks all for your work on this module, it is exactly what the group I'm helping out (its at campus habitat for humanity chapter) needs!

pwolanin’s picture

Ok, I'll look into it.

UMHockeyFan’s picture

Just wanted to give a little more information. After I upgraded from 4.7.6 to 5.1, the events were retained, but the site did not show any of the volunteer_timeslot functionality despite activating the module (basically, it was as if only the events module was installed). Although a link to create events with timeslots was shown in the navigation, the standard event content creation form showed up when I clicked on the link. I switched the site back to 4.7.6, as the volunteer timeslot functionality is a crucial function for the students who use the site. Thanks again for the help.

pwolanin’s picture

We're you trying to use HEAD with 5.x?

UMHockeyFan’s picture

Yes, I was using the HEAD module with 5.1.

pwolanin’s picture

StatusFileSize
new12.17 KB

haha, yes- just making a real go at the code now- some crucial pieces were not updated yet, like hook_node_info(), hook_view(), etc...

See attached patch. I'm committing these changes to HEAD, so now it would be reasonable to try the module out on a test site with your 4.7 data. There is no change to the schema, so no need to run update.php.

pwolanin’s picture

to be clearer- you can now try the module form HEAD with a 5.x test site and your data form your 4.7 site.

pwolanin’s picture

Status: Active » Reviewed & tested by the community
mbreed’s picture

I am able to install the module, and can create "Event with volunteer timeslots" content. However, it does not give me an option to specify the day or time. Rather, it creates an event at 12:00am on 1/1/1970.

Also, when its installed, I get the following error when I try to access my Admin page:

Fatal error: Allowed memory size of 10485760 bytes exhausted (tried to allocate 16 bytes) in /export/home/br/breedmr/public_html/dustin/includes/install.inc on line 43

pwolanin’s picture

There are many possibilities for problems- you don't list your PHP version, etc.

It's also possible that there was a problem with the install. Try visiting the node type page:

admin/content/types/volunteer-timeslots

and make sure this type is properly event enabled ("Show in event calendar"), or delete the module entry from the {system} table to force a full re-install.

The memory error is weird.

The module works fine for me AFAICT under Drupal 5.2-dev (head of the 5.x branch) with PHP 4.4.4 and MySQL 4.1.

UMHockeyFan’s picture

The module is working very well for me with a single exception: anonymous users are not able to view events with volunteer timeslots. The node is just a blank page - the other blocks on the page don't even generate. The basic events can, however, be viewed by anonymous users. I checked the Access Control settings and module settings, and I don't see anywhere where I can change this. I am using MySQL 4.1.21 and PHP 5.1.6. I do not know the webserver version our host is using, but I can find out if need be. Thanks.

pwolanin’s picture

Well, a white page of death doesn't not sound good. I'll try to look into it this evening. I'm preplexed as to where the problem could be.

Maybe it' a PHP 5.1 vs 4.4 issue? I do have a box with 5.1, so I'll give that a try.

pwolanin’s picture

Ok, starting to make some progress (at least in tracking down errors)

The admin page had the wrong path- I don't know if that's what was causing your problem with the admin page.

Now on my PHP 5.1 box, trying to access the event as anonymous I get:


Fatal error: Cannot use string offset as an array in /var/www/drupal/includes/theme.inc on line 552

N.B.- for reasons of laziness, etc the thing anyonmous users see is actually just the form with no checkboxes or submit function gneerated by the same theme function.

pwolanin’s picture

StatusFileSize
new1.55 KB

Ok- tracked down that error- I had not updated hook_link() properly.

patch attached and committed to HEAD

UMHockeyFan’s picture

All seems to be working well now. I'll let you know if I find anything else. Thanks again!

pwolanin’s picture

Status: Reviewed & tested by the community » Fixed

Ok, this last version of the code released as 5.x-1.0. Please open a new issue if you find new bugs.

Anonymous’s picture

Status: Fixed » Closed (fixed)