When exporting a node type as part of a Feature, http://drupal.org/project/features, it would be nice if the Node Form Settings was exported automatically as well. Fortunately its very easy to accomplish this - I'm attaching a patch that adds this functionality.

CommentFileSizeAuthor
#7 patch-nodeformsettings-features-3.patch2.37 KBlelizondo
#3 nodeformsettings_features_2.patch1.36 KBvoxpelli
#2 nodeformsettings_features_2.patch1.34 KBvoxpelli
nodeformsettings_features.patch877 bytesvoxpelli

Comments

lelizondo’s picture

lelizondo commented
Status: Needs review » Fixed

Thanks, works great, I just added the comment variables. http://drupal.org/cvs?commit=503420

voxpelli’s picture

voxpelli commented
Version: 6.x-1.5 » 6.x-1.x-dev
Category: feature » bug
Status: Fixed » Needs review
StatusFileSize
new nodeformsettings_features_2.patch1.34 KB

There seems to be a shortcoming in my original patch - making it sometimes export the variables when they shouldn't be exported. here's a follow up patch.

voxpelli’s picture

voxpelli commented
StatusFileSize
new nodeformsettings_features_2.patch1.36 KB

There was a typo in the previous patch - fixed in this one.

lelizondo’s picture

lelizondo commented
Version: 6.x-1.x-dev » 6.x-2.x-dev

Exactly what was wrong? I implemented this on 6.x-2.x. 6.x-1.x is frozen.

voxpelli’s picture

voxpelli commented

It exported the variables on all features dependent on the node type - not only the feature exporting the node type - and it also exported the variables no matter if they had been exported in another feature or not. See #1078478: Multiple features and strongarm conflicts and #904558: Multiple features and strongarm conflicts for related issues.

lelizondo’s picture

lelizondo commented
Status: Needs review » Needs work

Well, then I should rewrite the patch, the reason for this is because 6.x-2.x has been rewritten and now instead of several variables, it only uses one for each content type and module (Comment Form Settings has been separated into its own module).

lelizondo’s picture

lelizondo commented
Status: Needs work » Needs review
StatusFileSize
new patch-nodeformsettings-features-3.patch2.37 KB

I've just remade the patch for 6.x-2.x based on your patch. Can you please test?

I also pushed a new branch "features" with the patch applied http://drupal.org/node/582610/git-instructions/features/nonmaintainer

kssundar’s picture

kssundar commented
Issue summary: View changes
Status: Needs review » Fixed

Ported to 6.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.