Drush rsync should support a --include-vcs argument

The really good reason is to not expose .svn in a production server. So we asume the usecase for rsync @dev @prod. Haven't tested but perhaps --include-paths does an override.

vcs files are excluded from rsync by default because it would be a Really Bad Thing to copy them over if the files were stored in a different repository on each machine. Copying the vcs files only makes sense if the files are stored in the same repository, but if that is the case, then usually one would use the vcs to transfer the files.

There is something odd about your use case. You say that you can't do an svn up on the target server; if that is the case, then why do you need to transfer the vcs files as part of the rsync operation? If you can't use the vcs, seems you wouldn't need them.

Perhaps this is why there is no option to suppress the --exclude=".svn" etc. in drush rsync.

rsync already works over ssh. Run your rsync command with -s and look at the shell command it prints out. You can copy and modify this command to make it do a remote svn up on your remote server if you want.

Oh, and it would be feasible -- easy, even, to add --include-vcs as a flag to drush rsync. I'm just not sure why you want to transfer the vcs files if you are using rsync instead of svn on the remote server.

Naw, that's a reasonable use case.

Regarding your workaround, you might want to consider using regular rsync with drush dd if you want to sync things like %files. I'll add your --include-vcs args sometime; trivial change, just need to test it and make sure it works okay.

I've found this issue because I share a similar use case.

Tried to override the exclude using --include="+.svn" and that don't appear to work.

Patch attached.

hi folks,

just chipping in with another use case for this feature. At the agency where I work, we are using a development workflow with aegir wherein we build the production platform with a drush makefile, with custom code checked out of a VCS repository (svn at the present time). In order to do this, we build the platform on the command line with the --working-copy arg to drush_make and import it with provision-save. (as described by Miguel Jacq here: http://lists.aegirproject.org/pipermail/aegir/2011-January/000026.html)

All this works beautifully, except for the use case where the production platform is located on an Aegir satellite server. Aegir's hub & spoke model uses drush rsync to copy platforms to remote servers, and the lack of a --include-vcs flag to drush means that all our work up to this point was in vain.

The patch in #9 looks decent to me, I can do a proper review if it helps to move this issue along.

thanks,

Adrian

Committed to 5.x-dev. Could optionally be backported to 4.x.

Yeah, I think this is pretty reasonable. Backported.