Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
8 Feb 2011 at 12:34 UTC
Updated:
3 Jan 2014 at 02:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
barrapontoThe patch itself needs review, while I'll take it as a task reviewing the typo-related issues and seeing if this patch makes sense.
btw, the patch is big (160kb) because there was a typo in the 60k of aaaaaaa lines (in comments, of course).
Comment #2
andypostSounds useful
Comment #3
lars toomre commentedGood to see quite a few core spelling mistakes caught by this script... Rather than creating one massive core patch that is overwhelming to review, perhaps this patch file could be broken up into chunks of say 25 spelling mistakes? It would be easier to review and get committed I suspect.
Ideally this functionality in time could be added to the coder module. Great find!!
Comment #4
damien tournoud commented(... and others like this one)
This only affect comments and some UI strings, so it should be safe otherwise.
Comment #5
barrapontoFixed the error Damien Tournoud pointed out, ran a newer version of codespell.py against latest drupal.
I'm attaching a review file to make it easier to see what has been fixed.
Comment #6
lars toomre commentedAll of those spelling changes in review.txt look good, including the doens't highlighted by Damien Tournoud. I did not check each in turn in the patch file, but presume that changes are like before.
Comment #7
damien tournoud commentedLooks all good. Thanks for the patch!
Comment #8
klausidoes not apply anymore
Comment #9
barrapontoOnce again.
Comment #11
mac_weber commentedI reviewed 1054848-drupal-codespell-9.patch looks good.
Why not getting rid of that aaaaaaaaaa.... comment, too?
The comment is: "A large comment block to test for segfaults and speed. This is 60K a's. Extreme but useful to demonstrate flaws in comment striping regexp. aaaa..."
Located at line 7 of
./modules/simpletest/files/css_test_files/comment_hacks.css.unoptimized.cssWe really need that?
Comment #12
mac_weber commented#9: 1054848-drupal-codespell-9.patch queued for re-testing.
Comment #13
mac_weber commentedComment #14
chx commentedAnyone running screaming due to the size of the patch: 120K is from the 60k A used for the css tests *twice* because it's context for a line of change. Joys of patch.
Comment #15
dries commentedReviewed all the changes and committed the patch to 8.x.
The patch doesn't apply to 7.x so I couldn't backport it. Probably easiest to run codespell.py on 7.x.
Thanks!
Comment #16
barrapontoRan codespell.py on the 7.x branch.
Comment #17
klausiComment #18
mac_weber commentedComment #19
webchickOk, since the RTBC queue is looking pretty good around now, seems like it makes sense to commit this now. SO...
Committed and pushed to 7.x. Thanks! Yay, better spelling. ;)