While migrating an older site to Drupal 5, I noticed that there were some errors: Module files weren’t found. The attached patch fixes the old update function to update correctly to Drupal 5.

Why fix old update functions? Usually, old updates are not modified but new updates are added. In this case however, we need to change the old functions because the hardcoded module path does no longer exist in Drupal 5 (modules moved to their own directory).

CommentFileSizeAuthor
#7 update_24.patch1.03 KBChrisKennedy
#5 update_23.patch1019 bytesRobRoy
#3 update_22.patch1019 bytesRobRoy
update-update.patch1.04 KBkkaefer

Comments

dries’s picture

dries commented
Status: Needs review » Fixed

Good catch. Committed this to CVS HEAD. Thanks again.

RobRoy’s picture

RobRoy commented
Status: Fixed » Needs work

Shouldn't those include the ./ like "include_once './'. drupal_get_path('module', ..."?

RobRoy’s picture

RobRoy commented
Status: Needs work » Needs review
StatusFileSize
new update_22.patch1019 bytes

Actually, I just updated from HEAD and it doesn't look like this was committed in the first place. So here is a patch with the proper './' in there too.

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs review » Needs work

(Minor) Spacing error in the string concatenation of the second modification.

RobRoy’s picture

RobRoy commented
Status: Needs work » Needs review
StatusFileSize
new update_23.patch1019 bytes

Man, I'm usually a stickler for those too. Should have double checked the edit. Thanks Chris. :P

dries’s picture

dries commented

Patch looks good but doesn't apply? Odd.

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new update_24.patch1.03 KB

It just wasn't rolled from the root directory.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)