Yet another PHP 5.3 strict warning with a trivial fix: add $short = FALSE to ui_name().

CommentFileSizeAuthor
#5 ui_name_1049982.patch3.34 KBfgm
#1 ui_name_1049982.patch1.78 KBfgm

Comments

fgm’s picture

Status: Active » Needs review
Issue tags: +E_STRICT, +php5.3
StatusFileSize
new1.78 KB
bojanz’s picture

Status: Needs review » Reviewed & tested by the community

Patch needs -p1 to apply. In any case, the fix is correct.

dawehner’s picture

Version: 7.x-3.x-dev » 6.x-3.x-dev

This should should be commited to 6.x, too

merlinofchaos’s picture

[merlin@furor views]$ grep -R 'function ui_name()' modules/ handlers/ plugins/
handlers/views_handler_filter_group_by_numeric.inc:  function ui_name() {
handlers/views_handler_field_group_by_numeric.inc:  function ui_name() {
handlers/views_handler_argument_group_by_numeric.inc:  function ui_name() {
handlers/views_handler_sort_group_by_numeric.inc:  function ui_name() {

This doesn't seem to catch every case. Can we get them all at once?

fgm’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new3.34 KB

Rerolled against today's dev version.

dawehner’s picture

Status: Needs review » Fixed

It's looking great and had already RTBC. So commited to both branches.

Status: Fixed » Closed (fixed)
Issue tags: -E_STRICT, -php5.3

Automatically closed -- issue fixed for 2 weeks with no activity.