From another that I thought related : #945818: Fix the use of translated strings in the installer DatabaseTasks class

Regions in dashboard are not translated.

CommentFileSizeAuthor
#5 dashboard.module.patch552 bytesSebCorbin
dashboard.module.patch552 bytesSebCorbin

Comments

David_Rothstein’s picture

Title: Untranslated region strings » Dashboard region strings are untranslated

So I think this code might be OK as is.

You'll notice that the standard theme regions (listed in _system_rebuild_theme_data()) are not translated either. And many regions are defined in theme .info files, where they can't be translated because .info files aren't even PHP code.

So I think the intention is that theme regions are supposed to be translated on display only, which Drupal 6 did. But there appears to be a longstanding bug in Drupal 7 where it stopped doing that, so I filed a patch for that here: #1050686: Theme region names are no longer translated

One interesting question regarding Dashboard, though, is how the string extractor is supposed to find them when it parses the code looking for translatable strings? I think it already parses .info files looking for region names, and then has a hardcoded list for the ones defined in _system_rebuild_theme_data(). So perhaps we need to move this issue to http://drupal.org/project/potx to make sure that module has a way to pick up the dashboard region names also.

David_Rothstein’s picture

Status: Active » Needs review
David_Rothstein’s picture

Version: 7.0 » 7.x-dev

One more :)

Status: Needs review » Needs work

The last submitted patch, dashboard.module.patch, failed testing.

SebCorbin’s picture

StatusFileSize
new552 bytes

My patch failed, I may have worked on the stable release though, sorry about that.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.