theme_enable() and theme_disable() have a return; at the end of each function for no apparent reason.

CommentFileSizeAuthor
#5 1049144-remove-return.patch638 bytesboombatower
#1 1049144-remove-return.patch611 bytesboombatower

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new 1049144-remove-return.patch611 bytes
David_Rothstein’s picture

David_Rothstein commented
Title: Remove unnecessary return's » Remove unnecessary return statements
Version: 8.x-dev » 7.x-dev
Status: Needs review » Reviewed & tested by the community

They do indeed! And no reason to wait until D8 to kill them, either :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1049144-remove-return.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Needs to be rolled from the root directory...

boombatower’s picture

boombatower commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 1049144-remove-return.patch638 bytes

Woops :)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.