Name of vocabulary (Tags) created during install cannot be localized

@jyyna your patches were both reverse patches

rerolling jyyna's patch

Looks good to me.

I actually think the patch has a subtle problem, because the vocabulary name gets re-used later on in the same function:

  $instance = array(
    ....
    'label' => $vocabulary->name,
    ....
  );
  field_create_instance($instance);

As far as I know, instance labels aren't supposed to be translated before going into the database (they get translated on display instead).

So I think we need to ensure that the version used for the instance label remains untranslated, even if we are translating the one that goes into taxonomy_vocabulary_save().

I think Drupal core, at least, makes the assumption that field labels (even those entered via the UI) are interface text, and therefore supposed to be entered in English but translated on display. I know it doesn't make much sense, but that seems to be the way it works.

For example, none of the other fields added in the install profile have translated labels, nor does the body field when added via this API function:
http://api.drupal.org/api/drupal/modules--node--node.module/function/nod...

And if you go to admin/structure/types/manage/article/fields on a non-English site, you will see that there, the labels are in English. But if you go to node/add/article, the same labels will be translated for you.

I just discovered #1016006: Default title, body and other field labels not localizable which is related to this.

Hrm, I'm confused as to why the vocabulary description is translated then.

Yeah, there might be something wrong with the way field descriptions are handled too. Overall, this is very confusing!

Anyway, my suggestion above was that we simply do the attached patch for now. Does that work? That way the vocabulary name gets translated, but the field label is left alone (and remains untranslated just like all the others). Then we can leave it up to #1016006: Default title, body and other field labels not localizable to figure out how to handle field translation.

Translating vocabulary name and NOT translating label of that field seems to me as a strange (one more string to translate and label Tags still present on all nodes of Basic page and Article content types).

No, that's not correct. The label "Tags", and all other field labels, are already run through the translation system when they appear on nodes and other similar pages; that is what I have been saying above. You can see this yourself - just add a custom translation for the word "Tags" on your site, and it will work perfectly fine on those pages.

With this patch, not only do we fix the vocabulary translation issue directly, but now that we are adding this as a translatable string (which translators will start picking up and actually translating), that means it will automatically start being used for the field label also. Everyone wins.

Bumping to 8.x

#13: standard-install-translate-tags-1048006-13.patch queued for re-testing.

Committed to 7.x and 8.x. Thanks.

removing "needs backport to D7" tag