Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Wrong format plural string in system admin (both are same):
// system.admin.inc:1032
$items[] = format_plural(count($info['depends']), 'The @module module is missing, so the following module will be disabled: @depends.', 'The @module module is missing, so the following module>>s<< will be disabled: @depends.', $t_argument);
Found by @my-family during translation session
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 1047920-8_format_plural_count_system_admin.patch | 940 bytes | wojtha |
| #9 | 1047920-9_format_plural_count_system_admin.patch | 938 bytes | wojtha |
| #1 | d7_plural_system_admin_1047920.patch | 922 bytes | wojtha |
Comments
Comment #1
wojtha CreditAttribution: wojtha commentedComment #2
wojtha CreditAttribution: wojtha commentedComment #3
wojtha CreditAttribution: wojtha commentedbumping to 8.x
Comment #4
wojtha CreditAttribution: wojtha commented#1: d7_plural_system_admin_1047920.patch queued for re-testing.
Comment #6
wojtha CreditAttribution: wojtha commentedHmm, fixed in #1099254: Typo in modules/system/system.admin.inc, so marking this as duplicate.
Comment #7
Damien Tournoud CreditAttribution: Damien Tournoud commentedNot really. format_plural() requires a @count in $plural. It is not optional: not having a @count would break all the languages that have more then 2 plural forms.
Comment #8
wojtha CreditAttribution: wojtha commented@Damien: Ok, renaming the issue to match the problem accurately
The placeholder @count is now included in $plural.
Edit: this test fails because of the following test assertion, so if we want this variant we just need to edit this string too. But the next patch (singular unchanged) is better IMHO.
Comment #9
wojtha CreditAttribution: wojtha commentedAlternative patch which changes only the $plural form and leaves the $singular form unchanged.
Comment #10
wojtha CreditAttribution: wojtha commented#8: 1047920-8_format_plural_count_system_admin.patch queued for re-testing.
Comment #11
pillarsdotnet CreditAttribution: pillarsdotnet commented#9: 1047920-9_format_plural_count_system_admin.patch queued for re-testing.
Comment #12
pillarsdotnet CreditAttribution: pillarsdotnet commented#9: 1047920-9_format_plural_count_system_admin.patch queued for re-testing.
Comment #13
wojtha CreditAttribution: wojtha commented@pillarsdotnet, passed again - RTBC please ;-)
Comment #14
pillarsdotnet CreditAttribution: pillarsdotnet commented@wojtha -- Looks good to me, but I don't think I'm qualified to RTBC yet, as I've not had a patch of my own RTBC'd and accepted into core.
Marking RTBC anyway, as I doubt that it makes any difference while there are 16 criticals and 100 majors ahead of this in the queue.
Comment #15
wojtha CreditAttribution: wojtha commented@pillarsdotnet thx, you don't need to remind me this... several of these criticals or majors are also "mine" ... but after 4 months of vacuum I feel that the core is finally moving again...
Comment #16
pillarsdotnet CreditAttribution: pillarsdotnet commented#9: 1047920-9_format_plural_count_system_admin.patch queued for re-testing.
Comment #17
webchickCommitted to 8.x and 7.x, thanks!
Tagging as string freeze, since this will break existing translations (for the better, though).
Comment #19
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedMarked #755376: Wrong plural string in system.admin.inc as a duplicate.