Title pretty much says it all. We should be using $t() and not t() directly since this executes during install.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1046784-simpletest-requirements-t.patch | 3.1 KB | dave reid |
Title pretty much says it all. We should be using $t() and not t() directly since this executes during install.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1046784-simpletest-requirements-t.patch | 3.1 KB | dave reid |
Comments
Comment #1
dave reidComment #2
bfroehle commentedThe patch in #1 catches all instances of t() in simpletest_requirements(). Some nice whitespace fixes as well.
Comment #3
dries commentedWhat about these?
Comment #4
bfroehle commentedWith the exception of one instance of t() in system.api.php (which we should have be correct to set a good example), the remainder are all within
if ($phase == 'runtime')blocks.Is it worth converting those all to use $t?
Comment #5
dries commentedAh, no, you're right. Thanks for checking all of those, Dave. Committed the patch in #1 to CVS HEAD.
Comment #6
bfroehle commentedFollow up issue for the occurrence of t() in hook_requirements() of simple.api.php in #1056416: Strings in hook_requirements() api example not using $t.