Here's a patch that cleans up the undefined $output variable from the hook_help functions for uc_userpoints_product, uc_userpoints_award, and uc_userpoints_payment. $output was trying to be returned on all paths, thus throwing the error. I've shortened the functions to simply return the call to t() rather than assigning it to a variable first.
Please review and consider applying to latest dev.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | uc_userpoints_notices_nows.patch | 2.83 KB | torgospizza |
| uc_userpoints_notices.patch | 54.12 KB | torgospizza |
Comments
Comment #1
torgospizzaIt looks like my patch also fixes some whitespace issues. If you'd like I can re-roll the patch, but if you examine it closely you'll see it doesn't actually change anything in the code, apart from the hook_help functions as I mentioned.
Let me know if I should re-roll the patch without the whitespace fixes.
Comment #2
torgospizzaI decided to re-roll the patch without the whitespace changes. Makes it easier to read too; we can cleanup the whitespace in another patch.
Comment #3
bmagistro commentedWas looking at the first patch and agree, cleaning the code up might be better left to another patch. Should be in the D6-2.x. I'm relearning cvs commands, been awhile.. Thanks for your help with this.
Comment #4
torgospizzaNo problem! Since they were errors that were thrown on every page load, it was a good one to fix :)