Update.php is missing some CSS formatting [#103280]

update.php is missing some of the CSS required to make it look right - collapsible fieldsets for one aren't fully collapsing...

Most likely due to: http://drupal.org/cvs?commit=48032

Marking critical as this blocks RC1.

Comment	File	Size	Author
#3	maintenance_css.patch	1.16 KB	edmund.kwok
#3
#2	patch_77.txt	1.14 KB	webernet
#1	patch_76.txt	1.09 KB	webernet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

webernet CreditAttribution: webernet commented 14 December 2006 at 14:56

Status:

Active

» Needs review

File	Size
patch_76.txt	1.09 KB

Patch adds system.css and defaults.css to all maintenance pages.

Not the cleanest solution, but this problem stems from http://drupal.org/node/93079 where the calls to drupal_add_css() etc were removed...

Comment #2

webernet CreditAttribution: webernet commented 14 December 2006 at 15:07

File	Size
patch_77.txt	1.14 KB

Revised patch uses drupal_get_path().

Comment #3

edmund.kwok CreditAttribution: edmund.kwok commented 14 December 2006 at 15:24

Status:

Needs review

» Reviewed & tested by the community

File	Size
maintenance_css.patch	1.16 KB

Rerolled, minor coding style issues. Fieldset in update.php collapsible after patch; guess its the only way to fix this without invoking the css preprocessor. Marking this RTBC :)

Comment #4

ChrisKennedy CreditAttribution: ChrisKennedy commented 14 December 2006 at 17:28

Patch fixes the collapsing for me on FF2, IE6, and Opera 9. I'm not sure why this is critical though - without the patch the fieldset just can't be collapsed but otherwise works fine.