Currently blocks still display even when no banners have been assigned to the banner. The module is still outputing the divs and the javascript, causing the block to show when it shouldn't.

CommentFileSizeAuthor
#2 show_block_with_enabled_banners.patch690 bytesac
#1 empty_blocks.patch861 bytesac

Comments

ac’s picture

ac
Primary language English
Location Perth
commented
Status: Active » Needs review
StatusFileSize
new empty_blocks.patch861 bytes

Thanks to Heine for this patch.

ac’s picture

ac
Primary language English
Location Perth
commented
StatusFileSize
new show_block_with_enabled_banners.patch690 bytes

Heine has updated this take into account the banner status.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: master » 4.7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Patch still applies and is working. Please commit.

wulff’s picture

wulff commented
Status: Reviewed & tested by the community » Fixed

Will be included in next commit of 4.7/5.0. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)