I used some time to figure out how "Language switcher block" works and want to start a new issue about improve the block help message.

but .... before posting, I found that there has a bug. Attached patch for bug fixing.

And block help message said we need language negotiation "set to something other than None". It's wrong in D7 but I'm not sure if this is also a bug.

in D7 accepts URL or Session only.

CommentFileSizeAuthor
#6 language_switcher_help-1026058-6.patch2.13 KBplach
locale_help.patch1.77 KBdroplet

Comments

Status: Needs review » Needs work

The last submitted patch, locale_help.patch, failed testing.

droplet’s picture

droplet commented
Status: Needs work » Needs review

locale_help.patch queued for re-testing.

droplet’s picture

droplet commented
Title: Improve Language switcher block help message » add back Language switcher block help message
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Component: locale.module » language system
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Looks good and works as advertised.

I don't think this needs tests.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Version: 7.x-dev » 8.x-dev
Status: Reviewed & tested by the community » Needs review

Bugs are fixed in the development version first, backported then.

Rerolled and fixed help text.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new language_switcher_help-1026058-6.patch2.13 KB

the patch...

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Related issue: #1082902: Improve language switcher usability.

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community

patch is okay.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue tags: +Needs backport to D7
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x. Thanks a lot! :)

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Needs backport to D7

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix, +Needs backport to D7

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.