Time ago description clarification [#1023792]

In the views_handler_field_date.inc file, the end of line 39 currently reads:

If "Time ago" this is the the number of different units to display, which defaults to two.

1) Grammar improvements: There is an extra "the" that should be removed and a comma should be added after "Time ago". (Amusing side note: the extra "the" has survived other patches. See #379602: Add another date format for the raw "time ago" value instead of t('%time ago') for instance.)

2) "defaults to two" could use a better description. I eventually guessed that "two" meant to enter a number into the form like 1 or 2 but "two" itself might be misleading

Feel free to modify this text as you choose. Here would be my suggested new text:

If "Time ago", enter the number of different time units to display, which defaults to 2.

Comment	File	Size	Author
#2	time-ago-Views-6-dev-handlers.patch	1.38 KB	jcarlson34
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dawehner

German

CreditAttribution: dawehner commented 12 January 2011 at 18:13

Version:

7.x-3.x-dev

» 6.x-3.x-dev

1) This is a problem in 6.x, too

Let's fix it first in d6.

Comment #2

jcarlson34 CreditAttribution: jcarlson34 commented 21 January 2011 at 00:34

Status:

Active

» Needs review

File	Size
time-ago-Views-6-dev-handlers.patch	1.38 KB

Here's a patch for the D6 version. Feel free to change the wording.

Comment #3

jcarlson34 CreditAttribution: jcarlson34 commented 2 February 2011 at 15:27

Dereine, is this issue fixed now? Looks like the D7 version of Views has a completely new way of handling time formats including time ago.

I haven't checked the 6.x-3.x version but I know you guys do a great job of code consistency so if it is changed there as well, this issue may be fixed.