7007 does a fetchall and this eats RAM. Like popcorn. I needed to change memory limit to several gigabytes for this update to run. And guess what? the update is nonreentrant. boo.

CommentFileSizeAuthor
#2 mollom.update-7007.2.patch3.42 KBsun

Comments

chx’s picture

chx commented

I did http://ex.privatepaste.com/fbf4c626d1 this to make it reentrant.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new mollom.update-7007.2.patch3.42 KB

Sorry, I apparently didn't find time to get back to this issue, and the linked pastebin of #1 no longer exists...

One year later, I suspect that almost everyone has run that update already. :-/

As we're about to create a new stable 2.0 release, and since the upgrade path to 2.x needs to truncate the {mollom} table either way, I'm going to remove all data changes in that update for the 2.x branch.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Committed to 7.x-2.x and 6.x-2.x.

Given that almost everyone updated to 7.x-1.1 already and the update in question is contained in that, it's too late to fix 1.x. Sorry.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 6284b22 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1023780 by sun: Fixed mollom_update_7007() is obsolete for 2.x.

  • Commit 6284b22 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1023780 by sun: Fixed mollom_update_7007() is obsolete for 2.x.