Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Very minor patch, but I saw that the assignment to $table is not used anywhere. Hopefully the testbot will detect if the call to drupal_get_schema('users') was intentional.
Comment | File | Size | Author |
---|---|---|---|
user_module-remove_cruft.patch | 547 bytes | pillarsdotnet | |
Comments
Comment #1
pillarsdotnet CreditAttribution: pillarsdotnet commentedtagging.
Comment #2
bfroehle CreditAttribution: bfroehle commentedLine that referenced
$table
was removed in #721436: Remove magical fairy saving of cruft from user_save().Comment #3
pillarsdotnet CreditAttribution: pillarsdotnet commentedYup; right here.
Comment #4
jhodgdonThis patch is certainly fine. $table is not used anywhere else in that function.
I guess that the call to drupal_get_schema() could have the side effect of calling all the hook_schema() and hook_schema_alter() implementations to compile the schema. However, that would happen only if the schema wasn't already cached. And anyway obviously it's not used in this function, so it should not be a problem to wait until something else needs the schema. And as noted in #2/#3, it was apparently just an oversight from a previous patch that removed the use of $table without removing the generation of it.
Comment #5
Dries CreditAttribution: Dries commentedGood catch. Committed to CVS HEAD. Thanks.