_registry_update() contains code:

$transaction = db_transaction();
try {
   // ...
}
catch (Exception $e) {
  $transaction->rollback('registry', $e->getMessage(), array(), WATCHDOG_ERROR);
  throw $e;
}

Shouldn't the catch statement be

$transaction->rollback();
watchdog('registry', $e->getMessage(), array(), WATCHDOG_ERROR);
throw $e;

CommentFileSizeAuthor
#1 1022426-1-use_watchdog_exception.patch450 bytesbfroehle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bfroehle’s picture

Status: Active » Needs review
FileSize
450 bytes

And a patch. Note I've decided to use watchdog_exception('registry', $e); for the watchdog message as it seems more appropriate (and more commonly used).

catch’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Good catch. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.