If a contributed module contains a package variable specified without a value the system will display it at the top of the modules page. At the time of this post taxonomy_html is an example. The system should declare the value as Other just as if the package had not been specified to make the UI do what it was intended to do.

CommentFileSizeAuthor
#2 check-for-blank-package_0.patch814 bytesChrisKennedy
#1 check-for-blank-package.patch790 byteswebchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Active » Needs review
FileSize
check-for-blank-package.patch790 bytes

Ew. That looks quite nasty, indeed. For the record, the way to duplicate this bug is to include just:

package =

Without a package specified.

Here's a patch.

ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented
Component: base system » system.module
Status: Needs review » Reviewed & tested by the community
FileSize
check-for-blank-package_0.patch814 bytes

Tastes great, less filling. Re-rolled in root directory.

Jose Reyero’s picture

Jose Reyero CreditAttribution: Jose Reyero commented

Ok with the patch, but
any reason why the string 'Other' is not localized?

ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented

Translation occurs farther down in the file, see http://cvs.drupal.org/viewcvs/drupal/drupal/modules/system/system.module...

Steven’s picture

Steven CreditAttribution: Steven commented
Status: Reviewed & tested by the community » Fixed

Be graceful in what you accept, strict in what you output. -- Some wise guy

Committed to HEAD, thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)