Copying from admin_menu.map.inc:

            // @todo Make Comment module expose the original node type bundle,
            //   pretty please.
            if (drupal_substr($bundle_name, 0, 13) == 'comment_node_') {
              $bundle_name = drupal_substr($bundle_name, 13);
            }
CommentFileSizeAuthor
#6 drupal8.comment-node-bundle.6.patch776 bytessun
drupal.comment-node-bundle.0.patch951 bytessun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

drupal.comment-node-bundle.0.patch queued for re-testing.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Version: 7.x-dev » 8.x-dev
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: +Quick fix, +Needs backport to D7
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: -Quick fix, -Needs backport to D7

drupal.comment-node-bundle.0.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Quick fix, +Needs backport to D7

The last submitted patch, drupal.comment-node-bundle.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal8.comment-node-bundle.6.patch776 bytes

Re-rolled against latest branch head.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Status: Needs review » Reviewed & tested by the community

To me this looks like a sensible addition. The patch is very simple, and looks good to me.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented

The patch applies without offset to D7. So should be ready for straight backport.

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev

Looks good to me as well, I'm pretty sure I've had to figure out the node type back from the comment before as well.

Committed to 8.x, moving to 7.x for webchick to consider.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

This seems like a pretty harmless and convenient API addition. I'm comfortable committing to 7.x as well.

Committed/pushed. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Needs backport to D7

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix, +Needs backport to D7

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.