The attached patch improves l10n_client's presence in the installer the following ways:

(a) it exposes a checkbox which lets you decide to enable it or not
(b) if you enable it, it lets you enable sharing with localize.drupal.org
(c) if you enable sharing, it lets you enter your API key for user 1

(a) and (b) were hardwired before, and some people got surprised l10n_client is even there. Now they can disable it on install. (c) was not even there, so people still needed to do manual steps to configure it after installation, and were probably not aware.

Especially good is that the attached code uses Drupal 7 form API #states, so (b) and (c) items are hidden if (a) is unchecked and (c) is hidden if (b) is unchecked. Kinda neat. (a) and (b) are checked by default. I also tried to make the textbox appear required when sharing is enabled, but that did not display nice due to a core bug (submitted at #1017882: Required elements buggy with #states).

I tested this a lot, and it all seems to work, so committing it right away.

Comments

gábor hojtsy’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)

Needs to be backported to Drupal 6 if at all possible (probably not with the same lovely UI though unless we want to fill it all in with custom JS).

asrob’s picture

Issue summary: View changes
Status: Patch (to be ported) » Closed (won't fix)

I would close it because Drupal 6 EOL.