getsize was removed in #908282: Remove unnecessary I/O from theme_image() The api still shows the option is available.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

redndahead’s picture

Status: Active » Needs review
FileSize
1.13 KB
bfroehle’s picture

Title: Remove unused getsize option from theme_image_style » Clean-up 'getsize' remnants since it has been removed.
Status: Needs review » Needs work

A quick grep of the code shows that the getsize option isn't getting used anywhere in core. The patch in #1 takes care of two of these mentions, but it should be more thoroughly cleaned up.

[bfroehle@fortuna drupal (master)]$ find . -type f -print0 | xargs -0 egrep getsize
./modules/image/image.module:        'getsize' => TRUE,
./modules/image/image.module: *   - getsize: If set to TRUE, the image's dimension are fetched and added as
./modules/image/image.module:  // theme_image() can only honor the $getsize parameter with local file paths.
./modules/image/image.test:    $image_info['getsize'] = FALSE;
./modules/system/system.admin.inc:          'getsize' => FALSE,
redndahead’s picture

Status: Needs work » Needs review
FileSize
2.8 KB

These parts removed.

bfroehle’s picture

Many thanks, I'll mark it RTBC after the bot responds. (No rush, since it's likely too late for 7.0).

redndahead’s picture

ready for rtbc

bfroehle’s picture

Status: Needs review » Reviewed & tested by the community

As mentioned by redndahead, #908282: Remove unnecessary I/O from theme_image() removed the 'getsize' functionality and most 'getsize' mentions in the code. This patch removes 'getsize' documentation that was missed in that issue, as well as some stray 'getsize' references. Since that original issue is being used for another purpose at the moment, I'm marking this issue as RTBC. I've left a note in the other issue so they are aware of this change.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. If we decide to rollback #908282: Remove unnecessary I/O from theme_image() we can roll back it in one go. I'm not sure a rollback is the right approach so ...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.