Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
getsize was removed in #908282: Remove unnecessary I/O from theme_image() The api still shows the option is available.
Comment | File | Size | Author |
---|---|---|---|
#3 | 1015150-remove_getsize-2.patch | 2.8 KB | redndahead |
#1 | 1015150-remove_getsize-1.patch | 1.13 KB | redndahead |
Comments
Comment #1
redndahead CreditAttribution: redndahead commentedComment #2
bfroehle CreditAttribution: bfroehle commentedA quick grep of the code shows that the getsize option isn't getting used anywhere in core. The patch in #1 takes care of two of these mentions, but it should be more thoroughly cleaned up.
Comment #3
redndahead CreditAttribution: redndahead commentedThese parts removed.
Comment #4
bfroehle CreditAttribution: bfroehle commentedMany thanks, I'll mark it RTBC after the bot responds. (No rush, since it's likely too late for 7.0).
Comment #5
redndahead CreditAttribution: redndahead commentedready for rtbc
Comment #6
bfroehle CreditAttribution: bfroehle commentedAs mentioned by redndahead, #908282: Remove unnecessary I/O from theme_image() removed the 'getsize' functionality and most 'getsize' mentions in the code. This patch removes 'getsize' documentation that was missed in that issue, as well as some stray 'getsize' references. Since that original issue is being used for another purpose at the moment, I'm marking this issue as RTBC. I've left a note in the other issue so they are aware of this change.
Comment #7
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. If we decide to rollback #908282: Remove unnecessary I/O from theme_image() we can roll back it in one go. I'm not sure a rollback is the right approach so ...