Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Noticed that using variables in t() doesn't actually make them get translated since t() can't see the text in the variable.
Comment | File | Size | Author |
---|---|---|---|
#6 | 1014082-direct-t.patch | 591 bytes | dawehner |
#1 | views-t-1014082-1.patch | 3.39 KB | brenk28 |
Comments
Comment #1
brenk28 CreditAttribution: brenk28 commentedI've made some adjustments that may or may not be correct, can you please take a look?
Comment #2
dawehner.
Comment #3
bojanz CreditAttribution: bojanz commentedDidn't this get changed when the translation mega-patch got in? Are these left-overs?
Comment #4
merlinofchaos CreditAttribution: merlinofchaos commentedCopied straight from core. There's even an issue from when it went in, so that's definitely correct as-is.
Not sure about the others. Those do all seem like they should be translated with the view, not on output.
Comment #5
dawehnerYou seem to have a old version of views 3.x. There are already fixt some of this example, because the patch doesn't apply
Comment #6
dawehnerHere is a patch for the only place which makes sense: exposed_form
I'm not 100% sure about this part
But the others a fixed/by design, for example the node type label.
Comment #7
dawehnerCommited this patch to 6.x-3.x and 7.x-3.x the rest is still in discussion, but i guess it's either fixed or works as designed.
Comment #8
Patrick_Willam CreditAttribution: Patrick_Willam commentedNo further feedback in 6 months, therefore the problem seems to be solved by the commited patches.
Please re-try with current dev-version of Views and re-activate if necessary.