When processing a single payment, this module:
- Calls uc_order_load three times.
- Passes the entire $order object 6 times.

uc_order_load should be called once and a reference to the order object should be passed.

Cheers,

Antoine

CommentFileSizeAuthor
#1 uc_payflowpro-1013710.patch7.47 KBjantoine
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jantoine’s picture

jantoine CreditAttribution: jantoine commented
Status: Active » Needs review
FileSize
uc_payflowpro-1013710.patch7.47 KB

A patch is attached that also has some code cleanup per http://drupal.org/coding-standards.

Cheers,

Antoine

kwinters’s picture

kwinters CreditAttribution: kwinters commented
Priority: Normal » Minor

Changing priority to minor, since nothing is broken and it shouldn't have a significant performance impact (I'm pretty sure $order is static cached anyway). I'll still go over it when I get a chance.