Sorry guys, this was my fault. I attempted to fix the "more help" functionality and accidentally broke it. :P

This patch should take care of it.

CommentFileSizeAuthor
fix-more-help.patch786 byteswebchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Oh. To test, go on just about any of the pages which are sub-pages of a page with help text. For example, admin/build/menu/settings

ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented

Tested the patch and it fixed the problem.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Reviewed & tested by the community

Ok, marking RTBC then. Thanks!

dvessel’s picture

dvessel CreditAttribution: dvessel commented

How about combining this with http://drupal.org/node/100349 ?

The help more link displays in the main help pages. Minor issue but the link isn't needed in those pages.

dvessel’s picture

dvessel CreditAttribution: dvessel commented

Whoops, excuse me. Your patch actually fixes that issue too. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Closed (duplicate)

Actually, I like your fix better, and yours was technically posted first. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Closed (duplicate) » Reviewed & tested by the community

Oops. Ignore me, that one fixes a slightly different issue, which this one happens to fix.

dvessel’s picture

dvessel CreditAttribution: dvessel commented

What's preventing this from being committed?

Steven’s picture

Steven CreditAttribution: Steven commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD, thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)