Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
1 Jan 2011 at 11:41 UTC
Updated:
13 Apr 2019 at 18:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
radamiel commentedComment #2
avpadernoHello, and thank you for applying for a CVS account.
As per requirements, the motivation message should include more than two sentences used to describe the module features, and a comparison with the existing solutions.
Comment #3
radamiel commentedHashtags module provides alternative way of adding tags to node.
To add a tag in a such way you need to put the 'hash' or 'pound' symbol (#) preceding the any word in Body field when you add or edit a node.
Module works with standard taxonomy module. After activating module a new vocabulary is created and all tags, which added through body field will be the terms of this vocabulary.
This module works same way if user would add tags manually through the autocomplete textfield.
Also when someone views a node all hashtags words will be replaced to links on concreate terms.
This way of adding tags uses in Twitter.
See attached picture to understand how it looks like.
Comment #4
cleaver commentedI took a quick look at the module. A few things that would be good to clear up:
1. Why do you not add $vid as a parameter to db_query as you did with $nid?
2. Your install script attempts to install the schema for your module, but there is no implementation of hook_schema(). In fact, it doesn't look like there is any table at all.
3. Finally, more as a suggestion, it would be nice to have some facility to theme the links, or at a minimum add a css class. That shouldn't stand in the way of approving your account, though.
Comment #5
avpadernoSQL queries should use placeholders whenever the parameter is taken from a PHP variable (or from any dynamic values).
Comment #6
radamiel commentedThanks for replies. What have been fixed in a new version:
* SQL queries used placeholders for all parameters (hashtags.module - 83 str);
* added uninstall functionality (hashtags.install - 27 str);
* removed hook_install (hashtags.install);
* added css class for all hashtag links; (hashtags.module - 99 str);
Comment #7
cleaver commentedLooks like you've taken care of all of the points I've raised and the uninstall make sense.
I think you've met the guidelines for contrib access.
Let's see if kiamlaluno has any suggestions...
Comment #8
avpadernoIf the code has been changed, then it's all fine for me.
Comment #9
screenn commentedI think it's a very useful module, I'll use that. I was bored to add all the words to my cloud of tags by hands, and think will be better just to hash my words in body field.
Comment #12
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #13
avpadernoI am giving credits to the users who actively participated in this issue.