Call to undefined function decode_entities IN common.inc

We have two issues here:

1. In Devel's

function devel_xhprof_enable() {
  if (devel_xhprof_is_enabled()) {
    if ($path = variable_get('devel_xhprof_directory', '')) {
      include_once $path . '/xhprof_lib/utils/xhprof_lib.php';
      include_once $path . '/xhprof_lib/utils/xhprof_runs.php';
      // @todo: consider a variable per-flag instead.
      xhprof_enable(XHPROF_FLAGS_CPU + XHPROF_FLAGS_MEMORY);
    }
  }
}

there could be some error checking.

2. The core error handler should be able to handle errors during hook_boot() without tripping over the missing decode_entities().

The error message, if we'd actually get to see it, might be good enough that #1 is ok as it is, so let's fix #2 first.

require_once is inefficient. We should at least wrap this in if (!function_exists ('decode_entities')).

I'm still setting this to 'needs review' in order to get some feedback whether this is the right approach.

Looks proper to me.

This is the same patch, I only removed the trailing whitespace, so leaving as RTBC.

#4: de_4.patch queued for re-testing.

Test failures make no sens. The include should even never happen in the current test coverage, otherwise, tests should have been failing before. So this is patch is a no-op as far as the tests are concerned.

Back to RTBC as per #3.

Yeah, one of the test bots appears to be on crack again.

Committed to HEAD. Thanks!

Thanks all!

@droplet: Now what is the error message that you get from Devel (#1.1)? If we stilll need to do something there then please open a new follow-up issue in the Devel queue and link there.

Oh, and BTW, have you tried Devel's own Backtrace error handler? It should work from hook_boot(), too, or course...

(That wasn't intended so much as a hint but rather as a question whether Devel's Backtrace error handler needed fixing, too, when it's called in the same situation. IOW, does it have the same bug that you just fixed in core?)