Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neclimdul’s picture

Status: Active » Needs review
FileSize
245 KB

Why not, here's a quick stab at a patch. It might even work!

neclimdul’s picture

FileSize
244.66 KB

bah, lazy me. Correct patch format.

BTW, release announcement cites "official support for jQuery 1.4.4" which is the version used by Drupal currently so this is probably a good release to roll Drupal 7.0 with if we can.

Status: Needs review » Needs work

The last submitted patch, 1009862-jquery-ui-1.8.7.patch, failed testing.

neclimdul’s picture

Status: Needs work » Needs review
FileSize
0 bytes

blah... try again...

neclimdul’s picture

FileSize
247.93 KB

ugh.... I don't know what my problem is... this is actually a patch I promise! This just isn't a patch that can be made it git sadly.

neclimdul’s picture

FileSize
258.18 KB

Forgot the system.module changes for the library version numbers.

threewestwinds’s picture

Status: Needs review » Reviewed & tested by the community

Since I couldn't find any standardized script for testing jquery, I applied this patch and clicked around.

1) AJAX Examples (from the Examples module) still functions properly, for general jquery usage in ajax.js.
2) Vertical tabs, collapsible field sets and accordions still work (tested using Field Group module).
3) Progress bar still works (tested using Devel Generate).
4) Autocomplete, Resizeable and Image Upload widgits are fine (from the default Tags/Body/Image fields on an article).
5) Sortable is good (Field UI).
6) Dialog is good too (I believe that Chaos Tools AJAX Example uses it - it worked fine, whatever it does).
7) I don't believe we use draggable, droppable, selectable, datepicker or slider anywhere in core. But I see no reason why they would stop working, since all the API changes in 1.8.7 were optional additions.

General impression: it might have been a tad slower. It could be that I was just paying more attention than I usually do because I was testing.

The patch itself looks good. I didn't check carefully though all the changes inside the ui files themselves, since they're both compressed and not our responsibility. jQuery-UI folks finally got new lines at the end of all their files though, which is nice for consistency.

neclimdul’s picture

The new lines might have been done by vim when cleaning up the $Id$ tags...

threewestwinds’s picture

Forgot to note: I tested with Firefox 3.6 + Chrome 8. Might still need a quick check over by someone with Internet Explorer.

I'm leaving this RTBC, though - the main testing needed here was that 1.8.7 still plays nice with Drupal core and contrib, not to look for bugs in the library. jQuery-UI is well organized and sponsored - I think we can trust them to have tested their own library thoroughly.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Wow, great job testing, threewestwinds!

I'd feel better about this getting a pass with IE first but I agree that it's not Drupal's responsibility to fix IE issues in jQuery UI. I'll put out a plea tomorrow on Twitter asking for folks to test D7 in IE.

Committed to HEAD, with the addition of an adjustment to the version number in CHANGELOG.txt. Thanks!!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

amateescu’s picture

Title: Update to jQuery UI 1.8.7 » Update to jQuery UI 1.8.9
Status: Closed (fixed) » Needs review
FileSize
182.42 KB

How should we handle minor updates to jQuery UI in D7?

The changelogs for 1.8.8 and 1.8.9 shows that only bugfixes and a couple of new translations are included in these releases.

Attached is a patch that updates jQuery UI to 1.8.9. Is it ok to post it here or should I open a new issue for this?

Cyberwolf’s picture

Subscribing.

neclimdul’s picture

Title: Update to jQuery UI 1.8.9 » Update to jQuery UI 1.8.7
Status: Needs review » Closed (fixed)

Closing fixed at 1.8.7 and letting #1085590: Update to jQuery UI 1.9 take over. I'd personally prefer individual issues anyways to track any individual challenges.