Entity-7.x-1.0-beta5 contains nearly empty .info that serves no purpose [#1007542]

I tried to install this module using this tarbal http://ftp.drupal.org/files/projects/entity-7.x-1.0-beta5.tar.gz using Drupal-7.0-RC3, but obtained the following errors:

# Notice: Undefined index: name in update_verify_update_archive() (regel 706 van /modules/update/update.module). (11 times)
# entity-7.x-1.0-beta5.tar.gz contains versions of modules or themes that are not compatible with Drupal 7.x: , , , , , , , , , ,

Major: because it blocks the usage of the Organic Groups module

Comments

Comment #1

mageonyme commented 26 December 2010 at 16:03

Comment #2

EvanDonovan commented 26 December 2010 at 23:15

Looks like this is an error with the Update Manager in D7. Could you try installing the old-school way, and see if the same occurs?

Also, @mageonyme, what does it mean to +1 a bug report? That you are encountering it also?

Comment #3

radoeka commented 27 December 2010 at 08:18

Looks like this is an error with the Update Manager in D7

Or perhaps a packaging problem?

The update code does the following (modules/update/update.module):

    696   // Parse all the .info files and make sure they're compatible with this
    697   // version of Drupal core.
    698   $incompatible = array();
    699   $files = file_scan_directory("$directory/$project", '/^' . DRUPAL_PHP_FUNCTION_PATTERN . '\.info/',         array('key' => 'name', 'min_depth' => 0));
    700   foreach ($files as $key => $file) {
    701     // Get the .info file for the module or theme this file belongs to.
    702     $info = drupal_parse_info_file($file->uri);
    703 
    704     // If the module or theme is incompatible with Drupal core, set an error.
    705     if (empty($info['core']) || $info['core'] != DRUPAL_CORE_COMPATIBILITY) {
    706       $incompatible[] = $info['name'];
    707     }
    708   }

If I scan for the info files I get:
sites/all/modules/entity>
entity/entity.info
entity.info
entity_token.info
entity_metadata/entity_metadata.info
tests/entity_feature.info
tests/entity_test.info

Parsing the info results at line 702 fails, it seems. Now the question is what is wrong or missing in the info files.

Could you try installing the old-school way, and see if the same occurs?

It shows up, but that it possible because the D7.x compatibility check is not executed.

Also, @mageonyme, what does it mean to +1 a bug report? That you are encountering it also?

Probably and subscribing to the issue, so he / she gets the update on this issue.

Comment #4

dww

we/he/they

commented 27 December 2010 at 10:13

The problem appears to be in the entity/entity.info file. I have no idea why you left a basically empty .info file there with just a comment:

; This file is deprecated and may be removed.

But, that's what's confusing the update manager (and probably other parts of core, too). If it's deprecated, just remove it. ;)

Comment #5

mageonyme commented 27 December 2010 at 10:20

sorry
it was to subscrive to this bug report i had too...
i install with old-school way and it's ok.
thk u !

Comment #6

EvanDonovan commented 27 December 2010 at 13:46

Title:

Cannot install entity-7.x-1.0-beta5 error is: contains versions of modules or themes that are not compatible with Drupal 7.x

» Entity-7.x-1.0-beta5 contains nearly empty .info file that causes Update Manager install to fail

Thanks, dww, for coming to check it out. I didn't think of that possibility until after posting (I haven't used the module myself, just saw this issue linked in the comments on a Drupal Planet post).

Someone care to write a patch to fix or remove the errant .info file?

Comment #7

dww

we/he/they

commented 27 December 2010 at 13:50

Status:

Active

» Needs review

Pointless to write a patch. Instead, someone with commit access should do this from a CVS checkout:

cd contributions/modules/entity  # or wherever you checked out the module from
rm -f entity/entity.info
cvs rm entity/entity.info
cvs commit -m "#1007542: Removed empty info file that was confusing core Update manager" entity/entity.info

Comment #8

dww

we/he/they

commented 27 December 2010 at 14:03

Title:	Entity-7.x-1.0-beta5 contains nearly empty .info file that causes Update Manager install to fail	» Entity-7.x-1.0-beta5 contains nearly empty .info that serves no purpose
Priority:	Major	» Minor

Actually, upon closer inspection, it's not the empty .info file that's the problem. See #936490-76: Update module should verify downloaded tarballs and propagate errors correctly

You probably still want to remove that .info file, but it's certainly not a major bug in entity.