Links outside the overlay with existing fragments are broken

Seems to be a overlay bug. (I can't reproduce that if overlay is disable).

Overlay try to add is own fragment to the url. As long as the link to the comment append a fragment too, we have two fragment in the url (comment link + overlay context).
Maybe something to look in overlay-parent.js near

        // Add the overlay-context state to the link, so "overlay-restore" links
        // can restore the context.
        $target.attr('href', $.param.fragment(href, { 'overlay-context': this.getPath(window.location) + window.location.search }));

That means we can have the same problem with any link, inside the overlay, that ships with his own fragment.

Yes, this will be a problem with any link that's meant to close the overlay and already has a fragment. I'm not 100% sure what we want it to do though. The overlay-context behavior was added for the block demonstration page, but it's useful in any situation where you have a "go back to the admin page" type of link.

Maybe we should check the link before we add the overlay-context parameter to it, and if it has a fragment already, we leave it alone. Here's a patch that takes that approach. Comments welcome.

This works for me. Here's a post-corepocalypse reroll.

This looks pretty safe to backport, yeah?

Yes, should be safe to backport.

Makes sense, commited/pushed to 8.x, moving back to 7.x.

Thanks for the port scor. I have this patch running on several D7 sites.

Awesome, thanks!

Committed and pushed to 7.x.