Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The following notice is raised when using E_STRICT when testing:
Only variables should be passed by reference
The attached patch resolves this error.
Comment | File | Size | Author |
---|---|---|---|
#6 | 1005934-6.update-test-strict-notice.patch | 1.09 KB | dww |
#5 | update_update_test.diff | 940 bytes | rfw |
#4 | update_update_test_v3.diff | 948 bytes | rfw |
#2 | update_update_test_v2.diff | 738 bytes | rfw |
update_update_test.diff | 627 bytes | rfw | |
Comments
Comment #1
chx CreditAttribution: chx commentedConfirmed. While the code is the correct fix for this kind of error, we need a comment here to indicate why the --seemingly unncessary-- variable.
Comment #2
rfw CreditAttribution: rfw commentedAdded a comment about why temporary storage in a variable is required.
Comment #3
chx CreditAttribution: chx commentedComment #4
rfw CreditAttribution: rfw commentedAmended comment.
Comment #5
rfw CreditAttribution: rfw commentedWhoops, git diff prefices.
Comment #6
dwwRe-rolled to make the comment wrap to 80 characters, to use () after function names for clarity, and to do some minor tweaks to the text to make it read more clearly.
Since it's only nitpicks on the comment, even though it's my patch, I'm just going to RTBC it. ;)
Comment #7
webchickCommitted to HEAD. Thanks!