The menu title for aggregator.module's configuration page is "RSS aggregator" when it should just be "Aggregator". This is needed for both consistency and accuracy (i.e. the module isn't limited to RSS).

CommentFileSizeAuthor
#5 aggregator_name_0.patch2.97 KBChrisKennedy
#3 aggregator_name.patch2.97 KBChrisKennedy
aggregator_menurename.patch766 bytesChrisKennedy

Comments

ChrisKennedy’s picture

ChrisKennedy commented
Status: Active » Needs review

Should have set the status as CNR.

RobRoy’s picture

RobRoy commented

What about "Feed aggregator" so it's a little bit more explicit?

ChrisKennedy’s picture

ChrisKennedy commented
Title: Remove "RSS" from aggregator config menu title » String freeze: aggregator supports feeds other than RSS
StatusFileSize
new aggregator_name.patch2.97 KB

I looked at it some more and it already uses "News aggregator" in the module, so I changed it to that. I also found a few places where it says "RSS feed" unnecessarily.

RobRoy’s picture

RobRoy commented
Status: Needs review » Needs work

D5 uses Sentence capitalization for menu items so "News Aggregator" should be "News aggregator". Otherwise, looks like a good terminology cleanup.

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new aggregator_name_0.patch2.97 KB

Oops, good call.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)