This borders a typo.... but it stops you from writing a driver called mysql_foo extending mysql.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | dbtype.patch | 421 bytes | chx |
| dbtng_is_very_broken.patch | 640 bytes | chx |
This borders a typo.... but it stops you from writing a driver called mysql_foo extending mysql.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | dbtype.patch | 421 bytes | chx |
| dbtng_is_very_broken.patch | 640 bytes | chx |
Comments
Comment #1
chx commentedOh and note that core has all three equal driver and databaseType. So you do not see this. Also note that writing a test for this is impossible as drivers are hardwired into includes/database for D7.
Comment #2
carlos8f commentedOops. But Drupal works fine with the provided drivers, thus not critical.
Comment #3
chx commentedComment #4
Crell commentedSo to clarify here, we have two methods, driver() and databaseType(). The difference between the two is subtle and not exposed in core directly, but does exist. The documentation for driver() makes it clear how they differ but databaseType()'s does not. #3 makes databaseType()'s documentation clearer as well to reduce confusion (such as the confusion that prompted this issue in the first place).
Comment #5
webchickCommitted to HEAD. Thanks!
Comment #6
chx commentedWe totally and absolutely should rename this to PDOdriver...
Comment #7
jhedstromIssue summary needs updating if #6 is still to be done.
Comment #8
chx commentedComment #12
daffie commented