CVS edit link for parkeyparker
My motivation for requesting CVS access lies in my development of a module that easily allows users to insert the tracking code from GoSquared's LiveStats analytics engine directly into their pages. Instead of simply inserting it in every page it allows for options of where to insert it, for example you can choose to track all pages including the admin pages or omit those so that they do not skew your usage information. As well as this it ties into the advanced functionality of the tracking code to allow the sending of the currently logged in username to the LiveStats site so that you can track users by their username, or if you choose their User ID. These are options which are defaulted to off in the first instance so that there can be no issues with people getting confused.Looking to the future GoSquared have just released an API which allows for drawing information from their systems and it would be good to include that in the module so that you can see that from one central place from your website instead of having to always load their website. This is still quite new and in testing but it is showing promising results and I hope to implement this soon.
As for my relation to the company GoSquared, they are a startup in London, UK who I started out beta testing the software and although still not directly affiliated with the company I now maintain a Joomla plugin and help with improving the WordPress plugin whilst they are busy improving the main application. For more information visit http://www.gosquared.com/ or a review of LiveStats on my blog: http://www.parkeyparker.co.uk/2010/10/review-gosquared%E2%80%99s-livesta...
Obviously, at the moment the size of the module is quite small but upon talking to GoSquared they are happy with the functionality as it currently mirrors that of their other offerings, this is just another very popular CMS that people use and that they want to be able to provide users with an easier way of inserting the tracking code with more control than they would otherwise have.
I know there are other tracking modules out there but this is a bespoke module for a company which want it branded as their own, I merely facilitate that by taking it off of their hands as a kind gesture. If you have any problems then please do let me know.
Thank you very much for taking the time to read this.
Aaron Parker
parkeyparker@gmail.com
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | LiveStats-drup6-0.2.1.tar_.gz | 3.47 KB | parkeyparker |
| #9 | LiveStats-drup7-0.2.1.tar_.gz | 3.43 KB | parkeyparker |
| #2 | livestats.tar_.gz | 4.01 KB | parkeyparker |
| #1 | livestats.zip | 2.82 KB | parkeyparker |
Comments
Comment #1
parkeyparker commentedAttached module code in .zip format.
Comment #2
parkeyparker commentedJust realized I had omitted the README.txt file. This has now been rectified and I have attached a new version of the module (Also it is a tar.gz archive this time)
Comment #3
avpadernoComment #4
parkeyparker commentedI just thought that I would add that the guidelines for requesting CVS access suggest that including a link to a demo of the module in use is good to help the application. This is obviously a problem with my module as my testing server uses my personal account with GoSquared. However I can arrange for another free account to be set up for testing purposes, however I do not wish to release the login details to everyone via a comment on here, so if a reviewer needs further information such as a demo, please get in touch as it is not at all difficult to arrange, just impractical in current circumstances :)
Comment #5
avpadernoThe demo link is required for a theme; I guess the requirements should be changed to be clearer.
Comment #6
parkeyparker commentedThe requirements might have been clear, I might just have misread them or something :P If there is anything you do need to know about GoSquared or indeed anything don't hesitate to ask :)
Comment #7
parkeyparker commentedHi,
I was just wondering if there was anything else I need to do for this as it is about a month after I submitted it, have I missed a tag or status somewhere? Or is it just a case of waiting for someone to get around to testing and checking my code? Sorry if that is the case, not really had experience with this type of system before where this is done through an issue tracker so it is possible I got something wrong.
If there is nothing more I can do I shall leave it in your very capable hands and work on some of the other plugins :)
Aaron
Comment #8
parkeyparker commentedComment #9
parkeyparker commentedI have just learnt about the coder module for both version 6.x and 7.x and as a result I have now ported my module to Drupal 7.x (a client requested it) and I have also run the Drupal 6.x module code through the coder module and fixed all of the minor errors in that as well. I am attaching both versions here. The Drupal 7.x module does not include tracking of admin pages as in Drupal 7.x they are now overlays and so it would not affect pageviews as you are not refreshing the page all of the time.
I hope this can help my application progress further as we have many clients who could benefit from this module but would rather get it from CVS.
Thanks in advance
Aaron
Comment #10
parkeyparker commentedIt's been nearly 2 months now and I haven't heard anything? Just wondering what the usual time frame is for this process? Or does it vary widely based on how many volunteers are free to look at the code?
Hope everything is well
Aaron
Comment #11
arianek commentedHi. Please read all the following and the links provided as this is very important information about your CVS Application:
Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications
Comment #12
parkeyparker commentedHello,
I have now migrated my project to Git and I was hoping to get it approved as a full project now so that our users can start benefiting from this plugin from an official source rather than getting it from Git which is only suggested to advanced users at present and we want to open up to our entire user base. This application is for a new module and the functionality hasn't changed since the above comments.
The link to the project on the Drupal Git is: http://drupal.org/sandbox/parkeyparker/1083772
Thanks
Aaron
Comment #13
parkeyparker commentedComment #14
parkeyparker commentedSo, 4 months in and I have still had no feedback yet. I understand it has been a bit hectic with the move to Git and things so I was starting to wonder if I had migrated successfully as I haven't seen anything to suggest any progress... Kinda hoping no news is good news, but if someone could take a quick look at this it would be great as we want to release this as soon as possible as customers are asking for it and prefer to get it from the Drupal site rather than our own as we are currently forced to do...
Thanks in advance
Aaron
Comment #15
heine commentedThank you for sharing!
I've added two issues (one major, one normal) that IMO need work / thought before approving.
Comment #16
parkeyparker commentedI have fixed both of those issues although feel free to point out a better way of implementing either.
Thanks
Aaron
Comment #17
heine commentedYou were a bit hasty :)
Comment #18
parkeyparker commentedYes indeed I was a bit hasty, but I have now fixed #1123760: JS as per your comments as well as another bug I encountered in my changes so am now setting this back to Needs Review.
Thanks
Aaron
Comment #19
sreynen commentedHi parkeyparker,
It looks like you covered both of Heine's issues. tim.plunkett opened a new issue at #1138976: Coding standard, and helpfully submitted a patch. If you can apply that patch, I'll try to quickly mark this as reviewed. You'll find instructions for that in the "Git instructions" tab on the project.
Comment #20
parkeyparker commentedI have now implemented the patch for the master branch but some changes are needed to sort out the Drupal v7 branch. This is due to how the admin overlay now works, so if you could base this application on the Drupal 6 module which works fine and is up to date then that would be great as I know what I need to do by using the patch as a guide to sor tout Drupal 7.
Thanks
Aaron
Comment #21
sreynen commentedLooks good. I don't think we need to wait on D7 coding standards improvements to move this forward.
Comment #22
gregglesThanks for your contribution, parkeyparker! Welcome to the community of project contributors on drupal.org.
I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks also to sreynen, heine, and timplunkett for helping review this application.
Comment #25
avpaderno