Many times, people configure a website so that the fonrt-facing theme is used for adding content instead of the admin theme. So the node add form for Bartik needs to look good. It needs some visual help.

screenshot of Bartik's node add form

Files: 
CommentFileSizeAuthor
#14 bartik_node_form_7-1000688-14.patch443 bytesKeyboardCowboy
PASSED: [[SimpleTest]]: [MySQL] 41,261 pass(es).
[ View ]
#13 1000688-node-form-css.png52.12 KBKeyboardCowboy
#12 1000688-bartik_node_form-8.patch666 bytesfranz
PASSED: [[SimpleTest]]: [MySQL] 54,114 pass(es).
[ View ]
#8 1000688-bartik_node_form-8.patch685 bytesArtistConk
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1000688-bartik_node_form-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#5 1000688-bartik_node_form-5.patch659 bytesArtistConk
PASSED: [[SimpleTest]]: [MySQL] 34,402 pass(es).
[ View ]
#2 1000688-bartik_node_form.patch639 bytesfranz
PASSED: [[SimpleTest]]: [MySQL] 33,576 pass(es).
[ View ]

Comments

jensimmons’s picture

I think there's a bit too much top padding on the 'panels' (items?) for the vertical tabs, too.

franz’s picture

Version:7.x-dev» 8.x-dev
Status:Active» Needs review
StatusFileSize
new639 bytes
PASSED: [[SimpleTest]]: [MySQL] 33,576 pass(es).
[ View ]

I did some CSS changes to fix those issues. I don't thing the padding inside VT is too much.

franz’s picture

Issue tags:+needs backport to D7

Adding tag

franz’s picture

Status:Needs review» Needs work

Ah, I guess the "Tags" description is still with a wrong font

ArtistConk’s picture

StatusFileSize
new659 bytes
PASSED: [[SimpleTest]]: [MySQL] 34,402 pass(es).
[ View ]

Rerolled for new D8 directory structure (/core).

ArtistConk’s picture

Status:Needs work» Needs review
franz’s picture

Status:Needs review» Needs work

@ArtistConk, please see my comment on #4

ArtistConk’s picture

Status:Needs work» Needs review
StatusFileSize
new685 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1000688-bartik_node_form-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

New patch with updated font for "Tags" description.

kscheirer’s picture

Retesting against latest HEAD since it has been over a year.

kscheirer’s picture

Issue tags:-needs backport to D7

#8: 1000688-bartik_node_form-8.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+needs backport to D7

The last submitted patch, 1000688-bartik_node_form-8.patch, failed testing.

franz’s picture

Status:Needs work» Needs review
StatusFileSize
new666 bytes
PASSED: [[SimpleTest]]: [MySQL] 54,114 pass(es).
[ View ]

Re-rolled

KeyboardCowboy’s picture

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new52.12 KB

Patch in #12 works as designed. Increased padding around image field. Correct font on node form labels.

KeyboardCowboy’s picture

StatusFileSize
new443 bytes
PASSED: [[SimpleTest]]: [MySQL] 41,261 pass(es).
[ View ]

Adding patch for D7.

KeyboardCowboy’s picture

Status:Reviewed & tested by the community» Patch (to be ported)

Changing status.

As of this comment, D8 patch has been tested and works. D7 patch needs to be ported and tested.

franz’s picture

Status:Patch (to be ported)» Reviewed & tested by the community

Thanks KeyboardCowboy, but leave it RTBC until it's committed to D8, otherwise it'll fall off the radar.

alexpott’s picture

Issue tags:-needs backport to D7

#14: bartik_node_form_7-1000688-14.patch queued for re-testing.

Status:Reviewed & tested by the community» Needs work
Issue tags:+needs backport to D7

The last submitted patch, bartik_node_form_7-1000688-14.patch, failed testing.

alexpott’s picture

Status:Needs work» Reviewed & tested by the community

Oops so #14 is the D7 patch

alexpott’s picture

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Committed 4f3fbf6 and pushed to 8.x. Thanks!

alexpott’s picture

Status:Patch (to be ported)» Needs review
Issue tags:-needs backport to D7

#14: bartik_node_form_7-1000688-14.patch queued for re-testing.