Synch all profile fields on every edit of user account

And a fix. I feel like loading a user is not a big deal. Also, the normal process of saving an account page already does load a lot of times so this isn't a big change to load it once more.

killes approved this in irc and it's now committed: http://drupal.org/cvs?commit=432390

We'll need to review this for D7 at some point but it may work there. Updating status/version for tracking.

I realize now that this is insufficient. We can't ask people "please edit your account and change every value and then change it back to what it should be" just to get the data synched down to the slave sites.

I think we should send all profile data marked as ready for synch on every edit.

Thanks, Juliangb - now committed http://drupal.org/cvs?commit=433282

A weird situation: the values don't seem to get saved into the profile_fields on groups.drupal.org until/unless the user edits their profile and saves it. Instead the data is stored in users.data. On chicago2011.scratch.drupal.org it works fine.

@robbiethegeek, thanks for the additional debugging details. I disabled the synch feature for g.d.o earlier today since someone had the problem and they worked with me in irc and we were unable to get it working properly. We're rolling out a new version of bakery to all the sites tomorrow, and updating g.d.o in general in the next two months - we can just try it out again and see if that somehow fixes it...

If we want to use user_save then we have to:

1) we have to load up all the profile fields on the site and make sure they are populated in the $user object even if they weren't sent in the stroopwafel
2) we have to loop over the potential $categories and call each one of them
3) we have to normalize the incoming data to adjust for cases where the "full_name" field on master is in a different profile category than it's in on the slave

Instead, I suggest we manually save the profile fields directly to profile_values and unset them before calling user_save and probably call user_save with just the category that is set on user/uid/edit (i.e. not a profile page).

coltrane and drumm agreed to this conceptually in irc. I'm documenting it here so I remember what to do and so others can comment on the proposed system.

OK, I think the attached patch will work.

Some tests I did:
1. Create profile fields on master in "a category".
2. Create matching fields on the slave in "a different category"
3. With a user that has accounts on both sides, edit/save their main account page, their "a category" page, any other page on their profile

Expected results: data is synched into profile fields and nothing extra is left is users.data.

1. Blank out a profile field on master.
Results: confirm it is blanked out on the slave.

coltrane informs me this needs moar patch.

Committed with a slight cleanup to the description of the bakery_get_profile_fields function since they key/value got changed mid work and I never changed the description http://drupal.org/cvs?commit=451820

Thanks for the review/fixups, Ben!