html5_user_geolocation_* is a heck of a prefix and having _user_ feels likely to hit a conflict. How about html5_userlocation?

$edit['location'] seems likely to conflict with the location module.

It seems it doesn't work without Javascript, is that true?

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented

Short names are now permanent. I could create a new project, but I'm okay with descriptive names, that's what tab completion is for. I don't think it will be a conflict since it is always _user_geolocation_

I expanded out $edit usage, http://drupal.org/cvs?commit=415606.

Right, needs JS. I added a not supported message that is hidden upon geolocation working.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Fixed

Seems great to me. Marking as fixed from my perspective.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.