As of admin-6.x-2.0-beta6, the module can no longer co-exist with the admin_menu module because of a hard PHP error: Cannot redeclare theme_admin_menu_item().

Also, the comment above the function (in admin/theme/theme.inc) has what looks like a typo, saying it's an alternative to itself.

/**
 * Alternative to theme_admin_menu_item().
 [...]
 */
function theme_admin_menu_item($link, $has_children, $menu = '', $in_active_trail = FALSE, $extra_class = NULL) {
CommentFileSizeAuthor
#7 admin_drilldown_theme_functions.patch4.98 KByhahn

Comments

yhahn’s picture

yhahn commented
Assigned: Unassigned » yhahn
Priority: Major » Critical

o, that's a #fail. will revert, as this is not strictly necessary.

yhahn’s picture

yhahn commented
Status: Active » Fixed

http://drupal.org/cvs?commit=404376

grantkruger’s picture

grantkruger
Location Portland
commented

The code remains in the official beta6 release.

abaddon’s picture

abaddon commented

for reference:
admin_menu issue: http://drupal.org/node/879712
why this change: http://drupal.org/node/841414

seanr’s picture

seanr
he/him
commented
Status: Fixed » Active

Returning this to active since there still isn't a release and this is a pretty critical bug.

yhahn’s picture

yhahn commented
Status: Active » Needs review

This patch renames the admin drilldown-related theme functions under the admin_drilldown namespace and adds the theme_menu_item() protection theme function mentioned above.

Would love testing & review before I commit and roll into a release.

yhahn’s picture

yhahn commented
StatusFileSize
new admin_drilldown_theme_functions.patch4.98 KB
abaddon’s picture

abaddon commented

tested and it works as expected, ive used -beta6 with the changes in this patch ported to it
i dont have admin_menu but shouldnt be any issues now

thank you

piratinha’s picture

piratinha commented

works perfectly with the admin_menu

thankx yhahn

yhahn’s picture

yhahn commented
Status: Needs review » Fixed

Committed here: http://drupal.org/cvs?commit=406228

Available in 2.0-rc1

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.