The attached file is a version for the DRUPAL-5-0 branch.

It should probably be committed, once tested/modified, to the new branch.

CommentFileSizeAuthor
#17 README_8.txt1.18 KBfgm
#10 poormanscron.tgz5.68 KBfgm
#7 poormanscron_patch.tar_0.gz1.71 KBjptavan
#4 poormanscron_patch.tar.gz1.63 KBfgm
#1 poormanscron.info130 bytesfgm
poormanscron50.patch4.05 KBfgm

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new poormanscron.info130 bytes

5.0 also needs the .info file. It is attached to this comment.

robloach’s picture

robloach
he/him
commented

Looks good to me so far...

harry slaughter’s picture

harry slaughter
Location Omaha NE USA
commented

patch tested.

seems to work fine.

will leave this installed on my HEAD sandbox and report any problems

you might want to uppercase the menu title for consistency.

change
'title' => t('poor man\'s cron'),
to
'title' => t('Poor man\'s cron'),

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Category: feature » task
StatusFileSize
new poormanscron_patch.tar.gz1.63 KB

Rerolled patch as you said.

The patch archive now contains both the patch and the .info file : I can't include it in the patch file itself because it does not yet exist in CVS.

harry slaughter’s picture

harry slaughter
Location Omaha NE USA
commented

I've had this on my 5.0 sandbox for a few days now. I had it set to run every 1 minute, just for fun.

One thing I've been experiencing on my site is the occassional blank page of death. It's only every so often. I have no evidence that it's PMC (yet).

Has anyone else had this problem?

anthon1’s picture

anthon1 commented

Its working good for me.

just a suggestion, but it would be prudent to include an explanation to the "Cron Run Intervals" numeric value. such as 60 = sixty minutes.

jptavan’s picture

jptavan commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new poormanscron_patch.tar_0.gz1.71 KB

Work for me, but the "poormanscron.info" should ommit the line : package = Site configuration

http://drupal.org/node/101009 :

If your module comes with other modules or is meant to be used exclusively with other modules, enter the name of the package here. If left blank, the module will be listed as 'Other'. In general, this field should only be used by large multi-module packages, or by modules meant to extend these packages, such as CCK, Views, E-Commerce, Organic Groups and the like. All other modules should leave this blank. As a guideline, four or more modules that depend on each other (or all on a single module) make a good candidate for a package. Fewer probably do not.

poormanscron_patch.tar.gz attachement is unchanged, except for the package line.

Eric Cosky’s picture

Eric Cosky commented

I'm unable to get the provided patches to apply without errors. It's probably something I'm doing wrong, but just in case it isn't I thought I'd mention it. Below is the TTY of getting the last patch, gunzip, untar, and patch command used in case it helps to see it.

I get the same output if I apply it to the current version from CVS or to the 4.7 version listed on the module page, and very similar output if I use any of the other patches provided here.

wget http://drupal.org/files/issues/poormanscron_patch.tar_0.gz
--23:21:07--  http://drupal.org/files/issues/poormanscron_patch.tar_0.gz
           => `poormanscron_patch.tar_0.gz'
Resolving drupal.org... 140.211.166.46, 140.211.166.61
Connecting to drupal.org|140.211.166.46|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1,755 (1.7K) [application/x-gzip]

100%[=================================================================================>] 1,755         --.--K/s

23:21:07 (53.99 MB/s) - `poormanscron_patch.tar_0.gz' saved [1755/1755]

[modules/poormanscron]$ gunzip poormanscron_patch.tar_0.gz
[modules/poormanscron]$ tar -xvf poormanscron_patch.tar_0
x poormanscron50.patch
x poormanscron.info

[modules/poormanscron]$ patch <poormanscron50.patch
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: modules/poormanscron/README.txt
|===================================================================
|RCS file: /cvs/drupal-contrib/contributions/modules/poormanscron/README.txt,v
|retrieving revision 1.4
|diff -u -r1.4 README.txt
|--- modules/poormanscron/README.txt    1 Nov 2005 15:18:48 -0000       1.4
|+++ modules/poormanscron/README.txt    20 Sep 2006 22:07:29 -0000
--------------------------
Patching file README.txt using Plan A...
Hunk #1 failed at 16.
1 out of 1 hunks failed--saving rejects to README.txt.rej
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: modules/poormanscron/poormanscron.module
|===================================================================
|RCS file: /cvs/drupal-contrib/contributions/modules/poormanscron/poormanscron.module,v
|retrieving revision 1.18
|diff -u -r1.18 poormanscron.module
|--- modules/poormanscron/poormanscron.module   6 Feb 2006 15:58:50 -0000       1.18
|+++ modules/poormanscron/poormanscron.module   12 Nov 2006 21:29:05 -0000
--------------------------
Patching file poormanscron.module using Plan A...
Hunk #1 failed at 12.
Hunk #2 failed at 31.
Hunk #3 failed at 56.
Hunk #4 failed at 95.
Hunk #5 failed at 149.
5 out of 5 hunks failed--saving rejects to poormanscron.module.rej
done

Thanks for any advice or fixes.

basicmagic.net’s picture

basicmagic.net commented

subscribe

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new poormanscron.tgz5.68 KB

Since there seems to be a problem with the patch format, here is the full module for 5.0

Eric Cosky’s picture

Eric Cosky commented

The tar worked for me, thanks.

litwol’s picture

litwol commented

thanks!

i was waiting long for this. it works well now.

it is however not compatible with Aggressive performance setting.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Reviewed & tested by the community » Needs review

litwol: this is interesting to know. Have you any idea why ?

And if so, any idea on how to make it work for aggressive performance setting, or at least make sure sysads are informed of this limitation (instead of believing it should be compatible and losing time for them and for support on IRC or here).

Retracting RTBC until we can clear that.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Reviewed & tested by the community

OK, I see why now: it's because poormanscron really depends on hook_exit(), and this is part of the forbidden hooks for modules designed to work with aggressive mode (see the beginning of the code at http://api.drupal.org/api/HEAD/function/system_performance_settings).

RTBC for me, but someone should create a DRUPAL-5 branch to commit, as this is not for 4.7.

Uwe Hermann’s picture

Uwe Hermann commented

Committed (with minor changes), thanks! I also created a proper release for 4.6, 4.7, and 5.x now...

Uwe Hermann’s picture

Uwe Hermann commented
Status: Reviewed & tested by the community » Fixed
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Fixed » Needs review
StatusFileSize
new README_8.txt1.18 KB

Sorry, an error in the README: I mentioned the old placement for modules, but 5.0 changed the rules as per http://drupal.org/node/53705.

Attached is the correct file.

Uwe Hermann’s picture

Uwe Hermann commented
Status: Needs review » Fixed

Fixed in 5.x-1.1, thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)