closure compiler does the optimisation job as expected.
However while improving performance on one end, it degrades performance on another.
I get drupal reports of this kind on 'cron.php' executions:
shell_exec() has been disabled for security reasons in .../www/sites/all/modules/closure_compiler/closure_compiler.module on line 267.

I did not analyse in precise detail, but I think that you test the availability of local execution on every cron job at least. This does not work in my case - my setup resorts to the Google server.

It would be nice if you could avoid testing with 'shell_exec' for cron.php execution if it is not a local script that is being used;

Comments

rwohleb’s picture

rwohleb
he/him
Primary language English
commented

It looks like line 107 in closure_compiler.module:

if (!closure_compiler_local_works() && (variable_get('closure_compiler_process_method', 1) == 0)) {

Should be:

if (!closure_compiler_local_available() && (variable_get('closure_compiler_process_method', 1) == 0)) {
nburles’s picture

nburles commented
Version: 6.x-1.3 » 6.x-1.4-beta1
Category: feature » bug
Status: Active » Needs review

Thanks for the report... I've had a look into the issue, and I don't believe your fix is ideal - for those users who are using local compilation, this will no longer check that their compilation works before then attempting to actually compile the files (which means a failure for each file, rather than just the one).

However, I have come up with an alternative that should fix it for you, and created a beta release - http://drupal.org/node/1983630

If you are still using the module, I would appreciate you testing it to see if it does indeed resolve it.

nburles’s picture

nburles commented
Version: 6.x-1.4-beta1 » 6.x-1.4
Status: Needs review » Fixed

I believe this should be fixed in version 1.4, if anyone tests this and find it is not then please re-open the issue.

nburles’s picture

nburles commented
Status: Fixed » Closed (fixed)