Hello,

Love this module, but quickly found a nasty bug.

If a user without css permission saves a page that has css previously enterd by another user, the css is lost.

I found the offending code and simply wrapped it with a user_access check.

I've attached a patch that fixes this issue. To be honest, this is my first patch submission, so let me know if it's done right.

Cheers.

CommentFileSizeAuthor
#2 css-permission-check-on-update.patch672 bytesProct0t

Comments

fax8’s picture

fax8 commented

Please share your patch with us .. I'll be glad to review it.

Proct0t’s picture

Proct0t commented
StatusFileSize
new css-permission-check-on-update.patch672 bytes

wouldya look at that, thought I had attached it.... here it is!

fax8’s picture

fax8 commented
Status: Needs review » Fixed

I had problems applying your patch but I just used the code and manually edited the css.module file. See http://drupal.org/cvs?commit=360960

Thanks!

fax8’s picture

fax8 commented

Backported to CSS for D5

Proct0t’s picture

Proct0t commented

Glad I can contribute! =D

If you don't mind, could you let me know what was wrong with the patch?

fax8’s picture

fax8 commented

Don't know exactly. It simply didn't applied..

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.