Closed (fixed)
Project:
Media: BlipTV
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Jan 2010 at 17:49 UTC
Updated:
15 Nov 2010 at 15:30 UTC
If you want resolve problem with validation of xhtml code in emfield module for blip.tv provider
1. Go to sites modules directory:
sites/default/all/modules/emfield/contrib/emvideo/providers/
2. Open bliptv.inc and locate the line 323
$output .= '<embed src="http://blip.tv/play/'. $embed_code .'" type="application/x-shockwave-flash" width="'. $width .'" height="'. $height .'" allowscriptaccess="always" allowfullscreen="true"></embed>';
3. Replace with this code:
$output .= '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" width="' . $width .'" height="'. $height .'">
<param name="movie" value="http://blip.tv/play/'. $embed_code . '" />
<param name="quality" value="high" />
<param name="bgcolor" value="#FFFFFF" />
<param name="wmode" value="transparent" />
<!--[if !IE]> <-->
<object data="http://blip.tv/play/'. $embed_code.'" width="'. $width .'" height="'. $height .'" type="application/x-shockwave-flash">
<param name="quality" value="high" />
<param name="bgcolor" value="#FFFFFF" />
<param name="pluginurl" value="http://www.adobe.com/go/getflashplayer" />
FAIL (the browser should render some flash content, not this).
</object>
<!--> <![endif]-->
</object>';
Tested on IE 8, FF3.5.x, Google Chrome3, Safari4
Comments
Comment #1
jacobmn commentedKudos forcebook, nice post... I really think this or a variation on this should be swapped out in the next release of the actual module. After all, who wants invalid code on their video embed pages? I have tested this in IE 6 & 7 as well and it works like a charm.
Comment #2
aaron commentedthanks; committed to emfield v1. moving to media: bliptv for porting.
Comment #3
aaron commentedcommitted; sorry it took so long for me to get back to this... thanks @forcebook!
Comment #5
jacobmn commentedNow, after using this for a while, I realize that I never fully tested this. It works great for embedding and leaves you with nicely valid code, but there is an important parameter missing. The code above does not allow the full screen button to function, leaving a confusing experience for the user, so I've just added that line to the code for both non-IE and IE:
This should be committed again, as this is going to be pretty important functionality for a lot of people.
Comment #6
forcebook commentedThanks for reply!
I put essentials functional valid code and miss put prameter for IE fullscreen.
Enjoy!
Comment #7
aaron commentedawesome, thanks everyone! got it committed, will roll a new release shortly.