For modules which set global $custom_theme, Skinr does not work correctly. skinr_current_theme() will return the default theme rather than the actual current theme. This is a problem for sites using modules such as domain_theme, which allows a different theme to be used for each domain.

The attached patch fixes the problem for me whether an admin theme is being used or not.

CommentFileSizeAuthor
skinr-current-theme.patch678 bytesjtsnow

Comments

jtsnow’s picture

jtsnow commented

This may be the same issue that is being reported in #681862: Skinr class not applied to Subsite.

ChrisBryant’s picture

ChrisBryant commented
Status: Active » Needs review

Thanks for the patch! Updating the status and I've asked Kathryn531 in #681862: Skinr class not applied to Subsite. to test the patch to see if it fixes that issue as well.

that0n3guy’s picture

that0n3guy commented

Awesome... this makes skinr work with modules: sections, page_theme, and themekey (and probably all those other duplicate type modules)

I patched 6.x-1.1 and all is good.

jacine’s picture

jacine
she/her
Location New York
commented

I wonder if this will fix the issues with the switchtheme module. That would be nice.

that0n3guy’s picture

that0n3guy commented

Oh also, is there a type-o on the patch? I removed the "\ No newline at end of file" to get the patch to go through.

kccmcck’s picture

kccmcck commented

It was indeed the same issue. The patch fixed my problems using Skinr in coordination with the Subsite module.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Fixed

Thank you for the patch jtsnow. It has been committed and 6.x.1.2 has been released.

moonray’s picture

moonray commented

This patch wasn't properly implemented. Now fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.